Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalized crafting progress across items/fluids/etc. #8266

Merged
merged 3 commits into from
Dec 7, 2024

Conversation

shartte
Copy link
Member

@shartte shartte commented Dec 7, 2024

Fixes #7321, and replace #8045.

Normalizes the progress of each key type to their "unit" amount (i.e. 1 bucket for fluid) and shows progress in percent.

@shartte
Copy link
Member Author

shartte commented Dec 7, 2024

I'll postpone changing the interface to be a %-based progress in the network packet in the next MC release.

@shartte shartte merged commit 5759cb7 into main Dec 7, 2024
6 checks passed
@shartte shartte deleted the normalized-crafting-progress branch December 7, 2024 19:51
shartte added a commit that referenced this pull request Dec 7, 2024
Fixes #7321, and replace
#8045.

Normalizes the progress of each key type to their "unit" amount (i.e. 1
bucket for fluid) and shows progress in percent.

---------

Co-authored-by: Simba98 <[email protected]>

(cherry picked from commit 5759cb7)
shartte added a commit that referenced this pull request Dec 8, 2024
Fixes #7321, and replace
#8045.

Normalizes the progress of each key type to their "unit" amount (i.e. 1
bucket for fluid) and shows progress in percent.

---------

Co-authored-by: Simba98 <[email protected]>

(cherry picked from commit 5759cb7)
(cherry picked from commit aa8e68f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect Craft Progress, fluid using 1 Bucket = 81000 Items.
2 participants